Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same sentry version #247

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Use the same sentry version #247

merged 2 commits into from
Nov 15, 2023

Conversation

trent-codecov
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06851c3) 95.62% compared to head (7809432) 95.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files         605      605           
  Lines       15528    15528           
=======================================
  Hits        14848    14848           
  Misses        680      680           
Flag Coverage Δ
unit 95.62% <ø> (ø)
unit-latest-uploader 95.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06851c3) 95.53% compared to head (f6e1cf2) 95.57%.

❗ Current head f6e1cf2 differs from pull request most recent head 7809432. Consider uploading reports for the commit 7809432 to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #247     +/-   ##
=======================================
+ Coverage   95.53   95.57   +0.04     
=======================================
  Files        719     719             
  Lines      15935   15922     -13     
=======================================
- Hits       15222   15216      -6     
+ Misses       713     706      -7     
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trent-codecov trent-codecov merged commit 8f09643 into main Nov 15, 2023
15 checks passed
@trent-codecov trent-codecov deleted the trent/sentry-version-fix branch November 15, 2023 05:22
scott-codecov added a commit that referenced this pull request Nov 17, 2023
* main:
  feat: Emit pubsub event when org token is updated (#241)
  perf: use new get_file_totals() report method for BranchContents (#252)
  feat: adjust benefits for team plan (#253)
  fix: Adjust Team plan pricing (#805) (#243)
  feat: Add Sentry user to admin panel (#702) (#232)
  metrics: update shared + add sentry traces to BranchContents GraphQL query path (#251)
  Use the same sentry version (#247)
  feat(logging): change access logging format to JSON (#249)
  Use alpine 3.18 (#245)
  fix(launchscripts): delete contents of prometheus multiproc dir, not dir itself (#244)
  Make migration info log less confusing (#221)
  Fix urllib and opentelemetry-instrumentation dependencies (#213)
  Updating workflows (#242)
  fix: Handle Shelter storage paths in upload download handler (#234)
  feat: Modify billing for Team plan (#637) (#225)
  fix: Upgrade Django version to fix security vulnerabilities (#239)
  Update small badge (#238)
  Send github oauth access token expiry with cookie (#237)
  fix: Skip login if GitHub OAuth does not return access_token (#236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants