Last version breaks Jenkins pipeline (not multibranch)

[sebastienvas]

[mixer] Running shell script

• curl -s https://codecov.io/bash

• bash /dev/stdin -K

  ---

/ | | |
| | ___ __| | ___ ___ _____ __
| | / _ \ / ` |/ _ / / _ \ \ / /
| || () | (| | __/ (| () \ V /
______/ _,|_|____/ _/
Bash-e4a745b

==> Jenkins CI detected.

And then nothing else. After some investigation I think the issue is in here
https://github.com/codecov/codecov-bash/blob/e4a745b/codecov#L416

I also find it really weird that the script still checks for CI even though I am passing in the arguments.

The last working version for us is:
https://github.com/codecov/codecov-bash/blob/d642346/codecov#L406

[ypconstante]

I started to use Codecov today and had this same problem.
The version in commit d642346 also solved the problem for me.

[sebastienvas]

I ended up changing my pipeline libraries to set GIT_COMMIT and GIT_BRANCH when checking out the code. More details at istio/test-infra@96c1bdb

[stevepeak]

Thank you for reporting. Do you have a suggestion on how to resolve this?

[sebastienvas]

One of the issues is that CI detection is happening regardless of argument passed in. Since I passed in arguments I did not expect CI detection to fail.

The second issues would be to update
https://github.com/codecov/codecov-bash/blob/master/codecov#L418
from :
[ ! -z "$BRANCH_NAME" ] && echo "$BRANCH_NAME")
to
|| echo "$BRANCH_NAME")
as it is done in here:
https://github.com/codecov/codecov-bash/blob/master/codecov#L420 for GIT_COMMIT

[richistron]

I'm having the same problem

[thomasrockhu]

Is this still an issue @sebastienvas @richistron?

[sebastienvas]

Haven't used codecov and jenkins in a while. Probably outdated.

…

On Tue, Sep 22, 2020, 21:15 Thomas Hu ***@***.***> wrote: Is this still an issue @sebastienvas <https://github.com/sebastienvas> @richistron <https://github.com/richistron>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEHTIZ2O7G2UAUJXFGTQ7ADSHFY5BANCNFSM4DHE5IHA> .