This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Handle newlines in .bowerrc #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting $bower_components, the .bowerrc file was first read into an environment variable, an this variable was then embedded in a $(python -c "...") construct. This failed for my build due to newlines in the .bowerrc file: $ bash <(curl -s https://codecov.io/bash) File "<string>", line 1 import json as j; print j.loads('{ ^ SyntaxError: EOL while scanning string literal We now simply let the Python JSON module read the .bowerrc file.
|
Great job! Thank you for the contribution! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting $bower_components, the .bowerrc file was first read into
an environment variable, an this variable was then embedded in a
$(python -c "...") construct. This failed for my build due to newlines
in the .bowerrc file:
We now simply let the Python JSON module read the .bowerrc file.