Merge pull request #37 from thornbill/gitlab-ci

Fix GitLab CI detection
codecov · Mar 2, 2017 · f224f6c · f224f6c
2 parents f0c8aeb + 5998040
commit f224f6c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/services/gitlab.js b/lib/services/gitlab.js
@@ -1,10 +1,9 @@
-// http://doc.gitlab.com/ci/examples/README.html#environmental-variables
-// https://gitlab.com/gitlab-org/gitlab-ci-runner/blob/master/lib/build.rb#L96
+// https://docs.gitlab.com/ce/ci/variables/README.html
 
 module.exports = {
 
   detect : function(){
-    return process.env.CI_SERVER_NAME == 'GitLab CI';
+    return !!process.env.GITLAB_CI;
   },
 
   configuration : function(){

diff --git a/test/services/gitlab.js b/test/services/gitlab.js
@@ -3,7 +3,7 @@ var gitlab = require("../../lib/services/gitlab");
 describe("Gitlab CI Provider", function(){
 
   it ("can detect gitlab", function(){
-    process.env.CI_SERVER_NAME = "GitLab CI";
+    process.env.GITLAB_CI = "true";
     expect(gitlab.detect()).to.be(true);
   });