-
Notifications
You must be signed in to change notification settings - Fork 113
fix: support .codecov.yml
/codecov.yml
files for token
#108
Conversation
package.json
Outdated
@@ -28,6 +28,8 @@ | |||
"dependencies": { | |||
"argv": "^0.0.2", | |||
"ignore-walk": "^3.0.1", | |||
"js-yaml": "^3.12.0", | |||
"mock-fs": "^4.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in the dev dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddiemoore done. also updated tests after the recent updates to master
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 88.05% 89.07% +1.01%
==========================================
Files 18 18
Lines 293 302 +9
Branches 73 79 +6
==========================================
+ Hits 258 269 +11
+ Misses 35 33 -2
Continue to review full report at Codecov.
|
package.json
Outdated
@@ -36,8 +36,10 @@ | |||
"eslint-config-prettier": "^2.9.0", | |||
"expect.js": "^0.3.1", | |||
"husky": "^0.14.3", | |||
"js-yaml": "^3.12.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I should have been more specific before. Only the mock-fs
needs to be in devDeps. js-yaml
would need to be in normal dependencies
as it's being used in the main library file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh duh...sorry wasn't thinking. updated.
ugh...seems like some sort of timeout issue with the tests:
and
i'll try rerunning this build b/c this test works locally for me. |
@eddiemoore ok seems like it was just a network issue WRT those failing tests. Can this be merged soon? |
Released in 3.1.0 |
⚡️👍⚡️ |
currently,
<rootDir>/.codecov.yml
and<rootDir>/.codecov.yml
are not recognized by this node package. it looks likequery.yaml
was getting blown away whenquery = detectProvider()
was called since currentlyquery.yaml
is assigned above it.I moved the
query.yaml
assignment after thequery = detectProvider()
call to maintain the yaml file reference.