Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

fix: support .codecov.yml/codecov.yml files for token #108

Merged
merged 5 commits into from
Sep 4, 2018

Conversation

hellatan
Copy link
Contributor

@hellatan hellatan commented Aug 16, 2018

currently, <rootDir>/.codecov.yml and <rootDir>/.codecov.yml are not recognized by this node package. it looks like query.yaml was getting blown away when query = detectProvider() was called since currently query.yaml is assigned above it.

I moved the query.yaml assignment after the query = detectProvider() call to maintain the yaml file reference.

package.json Outdated
@@ -28,6 +28,8 @@
"dependencies": {
"argv": "^0.0.2",
"ignore-walk": "^3.0.1",
"js-yaml": "^3.12.0",
"mock-fs": "^4.6.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the dev dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddiemoore done. also updated tests after the recent updates to master

@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #108 into master will increase coverage by 1.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   88.05%   89.07%   +1.01%     
==========================================
  Files          18       18              
  Lines         293      302       +9     
  Branches       73       79       +6     
==========================================
+ Hits          258      269      +11     
+ Misses         35       33       -2
Impacted Files Coverage Δ
lib/codecov.js 82.51% <100%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fff4dc...11fe406. Read the comment docs.

package.json Outdated
@@ -36,8 +36,10 @@
"eslint-config-prettier": "^2.9.0",
"expect.js": "^0.3.1",
"husky": "^0.14.3",
"js-yaml": "^3.12.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should have been more specific before. Only the mock-fs needs to be in devDeps. js-yaml would need to be in normal dependencies as it's being used in the main library file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh duh...sorry wasn't thinking. updated.

@hellatan
Copy link
Contributor Author

hellatan commented Sep 4, 2018

ugh...seems like some sort of timeout issue with the tests:

// node 10
  1) Codecov
       upload v2 doesn't throw runtime error:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/codecov/codecov-node/test/upload.js)

and

// node 5
  1) Codecov
       can remove files after uploading:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/codecov/codecov-node/test/upload.js)

i'll try rerunning this build b/c this test works locally for me.

@hellatan
Copy link
Contributor Author

hellatan commented Sep 4, 2018

@eddiemoore ok seems like it was just a network issue WRT those failing tests. Can this be merged soon?

@eddiemoore eddiemoore merged commit 7c1f16e into codecov:master Sep 4, 2018
@eddiemoore
Copy link
Collaborator

Released in 3.1.0

@hellatan
Copy link
Contributor Author

hellatan commented Sep 4, 2018

⚡️👍⚡️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants