Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Support CircleCI 2.0 #46

Merged
merged 4 commits into from
Feb 21, 2017
Merged

Support CircleCI 2.0 #46

merged 4 commits into from
Feb 21, 2017

Conversation

dtinth
Copy link
Contributor

@dtinth dtinth commented Feb 18, 2017

CircleCI 2.0, currently in closed beta, supports Docker out-of-the-box. It brings a lot of nice improvements.

However, there are changes in environment variables. The variables CIRCLE_PROJECT_USERNAME and CIRCLE_PROJECT_REPONAME has been removed.

This PR makes codecov-node support running inside CircleCI 2.0.

Output comparison

Before (bash version)

HTTP 400
slug must match pattern ^[\w\-\.]{1,255}\/[\w\-\.]{1,255}$

Coverage data is not uploaded.

Before (node version)

==> Detecting CI Provider
    Circle CI Detected
==> Configuration: 
    Endpoint: https://codecov.io
{ service: 'circleci',
  build: '70.0',
  job: '70.0',
  commit: '7d0aaca1f17ee2c56f4448d7d3c1e35fc838ddab',
  branch: 'my-record',
  pr: undefined,
  slug: 'undefined/undefined',
  package: 'node-v1.0.1' }
...
==> Uploading reports
    HTTP 400
Unable to locate build via CircleCI API. Please upload with the Codecov repository upload token to resolve issue.

Slug is undefined/undefined. Coverage data is not uploaded.

After (node version)

==> Detecting CI Provider
    Circle CI Detected
==> Configuration: 
    Endpoint: https://codecov.io
{ service: 'circleci',
  build: '71.0',
  job: '71.0',
  commit: 'e45d8b7e512e3110501f36c7814eae5c5cb97f26',
  branch: 'my-record',
  pr: undefined,
  slug: 'bemusic/scoreboard',
  package: 'node-v1.0.1' }
...
==> Uploading reports
    Success!
    View report at: https://codecov.io/github/bemusic/scoreboard/commit/e45d8b7e512e3110501f36c7814eae5c5cb97f26

Coverage data uploaded successfully, despite pr being undefined.

Codecov backend seems to return https link now.
@codecov
Copy link

codecov bot commented Feb 21, 2017

Codecov Report

Merging #46 into master will increase coverage by 5.23%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   91.41%   96.65%   +5.23%     
==========================================
  Files          17       17              
  Lines         233      239       +6     
  Branches       44       46       +2     
==========================================
+ Hits          213      231      +18     
+ Misses         20        8      -12
Impacted Files Coverage Δ
lib/services/circle.js 91.66% <83.33%> (-8.34%)
lib/codecov.js 95.08% <ø> (+2.45%)
lib/detect.js 92.85% <ø> (+21.42%)
lib/services/drone.js 100% <ø> (+27.27%)
lib/services/localGit.js 100% <ø> (+30.76%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2408ca9...e70ca5a. Read the comment docs.

@stevepeak
Copy link
Contributor

Awesome job! 👍

@stevepeak stevepeak requested review from eddiemoore and removed request for eddiemoore February 21, 2017 13:05
@stevepeak stevepeak merged commit f0c8aeb into codecov:master Feb 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants