Dart2 compatibility #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this be merged or is the repo dead? |
|
Can this be merged pleased indeed? |
|
@ChacaS0 Happy to merge this, but as Dart isn't a core competency of Codecov's engineering staff, would it be possible for you to point to the following:
Sorry to require the extra steps in this case, but it's likely the most straightforward way to demonstrate that this PR will bring Dart2 compatibility since I don't have the immediate tools or expertise to get this verified in-house. Anyone else interested in seeing this PR merged is more than welcome to perform the above. I'll merge the PR as soon as correctness of implementation can be shown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.