Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CE-1411] Bring project back to a passing state #17

Merged
merged 89 commits into from
Sep 21, 2020

Conversation

drazisil
Copy link
Contributor

This is a clone of #16, which would not show commit 1e04fca for some reason.

@drazisil
Copy link
Contributor Author

Seems to hang on the coverage step. Will investigate if @johnpryan 's thoughts in this comment #16 (comment) will change anything.

@drazisil drazisil changed the title Bring project back to a passing state [CE-1411] Bring project back to a passing state Feb 25, 2020
@thomasrockhu thomasrockhu mentioned this pull request Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #17 into master will increase coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #17      +/-   ##
=========================================
+ Coverage    4.34%   4.46%   +0.11%     
=========================================
  Files           5       5              
  Lines         207     224      +17     
=========================================
+ Hits            9      10       +1     
- Misses        198     214      +16     
Impacted Files Coverage Δ
bin/src/coverage.dart 0.00% <0.00%> (ø)
bin/src/executable.dart 0.00% <0.00%> (ø)
bin/src/test.dart 0.00% <0.00%> (ø)
bin/src/env.dart 100.00% <0.00%> (ø)
bin/generate_coverage.dart 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afd6c1...9a75dfe. Read the comment docs.

@thomasrockhu thomasrockhu requested a review from a team September 18, 2020 21:03
@thomasrockhu
Copy link
Contributor

@johnpryan, @ekweible, @drazisil-codecov I'm not a dart developer, but did my best here to get it back up to a passing state. Would love your eyes on this review.

@drazisil
Copy link
Contributor Author

We got a report out of it, so I'm happy. Will review monday when i have access

Copy link

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@thomasrockhu thomasrockhu merged commit 9b55b47 into master Sep 21, 2020
@thomasrockhu thomasrockhu deleted the drazisil-patch-1 branch September 21, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants