-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CE-1411] Bring project back to a passing state #17
Conversation
codecov.io/codecov/v4/raw/2020-02-21/6F3CFC3CB9FB2E93955727E8238F6328/60befd085c9412a49dbeedd631852922266e58c2/1694032a-5811-4951-bb1d-e5fd0161ae44.txt
Signed-off-by: Joe Becher <jwbecher@drazisil.com>
Seems to hang on the coverage step. Will investigate if @johnpryan 's thoughts in this comment #16 (comment) will change anything. |
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
+ Coverage 4.34% 4.46% +0.11%
=========================================
Files 5 5
Lines 207 224 +17
=========================================
+ Hits 9 10 +1
- Misses 198 214 +16
Continue to review full report at Codecov.
|
@johnpryan, @ekweible, @drazisil-codecov I'm not a dart developer, but did my best here to get it back up to a passing state. Would love your eyes on this review. |
We got a report out of it, so I'm happy. Will review monday when i have access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
This is a clone of #16, which would not show commit 1e04fca for some reason.