Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fetch to see if bundle or coverage is enabled on a repository for a given commit #2535

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in two new fields to be requested on when using useCommitPageData to check and see if either bundle analysis or coverage is enabled to determine what components to render on the Commit page, which will be coming soon.

GH codecov/engineering-team#996

Notable Changes

  • Update useCommitPageData to fetch bundleAnalysisEnabled and coverageEnabled fields
  • Update related tests

Copy link

codecov-public-qa bot commented Jan 24, 2024

Codecov Report

Merging #2535 (56e1be2) into main (432afdc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2535   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10395    10397    +2     
  Branches     2571     2573    +2     
=======================================
+ Hits        10220    10222    +2     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432afdc...56e1be2. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2535   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10395    10397    +2     
  Branches     2571     2571           
=======================================
+ Hits        10220    10222    +2     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432afdc...56e1be2. Read the comment docs.

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 56e1be2
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65b3bb8a7d272f000893ade5
😎 Deploy Preview https://deploy-preview-2535--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (432afdc) 98.32% compared to head (56e1be2) 98.32%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2535   +/-   ##
=====================================
  Coverage   98.32   98.32           
=====================================
  Files        803     803           
  Lines      10395   10397    +2     
  Branches    2571    2617   +46     
=====================================
+ Hits       10220   10222    +2     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432afdc...56e1be2. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (432afdc) 98.31% compared to head (56e1be2) 98.31%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2535   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10395    10397    +2     
  Branches     2571     2571           
=======================================
+ Hits        10220    10222    +2     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432afdc...56e1be2. Read the comment docs.

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2535.codecov.dev for your PR preview. Expires after 1 month automatically.

@nicholas-codecov nicholas-codecov merged commit a78abb5 into main Jan 26, 2024
60 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-996-fetch-to-see-if-bundle-or-coverage-is-enabled branch January 26, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants