feat: Putting it all together on the commit page #2542
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 811 811
Lines 10561 10599 +38
Branches 2633 2696 +63
=======================================
+ Hits 10386 10424 +38
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2542 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 811 811
Lines 10561 10599 +38
Branches 2635 2696 +61
=======================================
+ Hits 10386 10424 +38
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2542 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 811 811
Lines 10561 10599 +38
Branches 2684 2696 +12
=======================================
+ Hits 10386 10424 +38
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
=======================================
+ Coverage 98.34 98.35 +0.01
=======================================
Files 811 811
Lines 10561 10599 +38
Branches 2676 2696 +20
=======================================
+ Hits 10386 10424 +38
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit https://preview-pr-2542.codecov.dev for your PR preview. Expires after 1 month automatically. |
…ere is no coverage present
…th and also move it to TS
nicholas-codecov
force-pushed
the
gh-eng-996-putting-it-all-together-on-the-commit-page
branch
from
16eb5f4
to
4bb4039
Compare
| COVERAGE: 'coverage', | ||
| BUNDLE_ANALYSIS: 'bundle-analysis', | ||
| BOTH: 'both', | ||
| } as const |
There was a problem hiding this comment.
So it interprets the values as literals not just as strings.
| if ( | ||
| !isLoading && | ||
| !commitPageData?.commit && | ||
| !commitPageData?.isCurrentUserPartOfOrg |
There was a problem hiding this comment.
qq: why do we care if user is not part of org?
There was a problem hiding this comment.
This is the current logic in the commit detail page, and also untouched from when I restructured the commit detail page
nicholas-codecov
deleted the
gh-eng-996-putting-it-all-together-on-the-commit-page
branch
Description
This PR puts everything all together on the commit detail page to conditionally display coverage info, BA info, or both when both have been enabled. Updated error handling is on it's way, just waiting on some UI/UX designs to come in.
GH codecov/engineering-team#996
Note
Requires #2535, #2540, and #2541
Notable Changes
CommitDetailPageto conditionally render different contentsCommitDetailPageto TSScreenshots
Only coverage enabled:
Only BA data enabled:
Both uploaded (not expanded):
Both uploaded (expanded):