Incorrect Content-Type headers

[RA80533]

web.js uses incorrect headers to describe the Content-Type of the JSON payload.

[drazisil]

It you are referring to the PUT, the comment on

uploader/src/helpers/web.js

Line 40 in 5856d15

.send(uploadFile) // sends a JSON post body

is the incorrect part. The PUT does send a gzip

[RA80533]

Content-Type specifies the original content type whereas Content-Encoding specifies the compression, etc.

Content-Type should be JSON.

In terms of semantics, it might help to think of Content-Encoding as simply a box for whatever content it holds. There’s no such thing as sending “a gzip” because a gzip isn’t a thing itself—it’s what it contains that’s being sent, etc.

[RA80533]

If the Content-Type is not being handled in a way that respects the actual content of the underlying content type of what’s being sent, do the back-end services just assume that the content being uploaded is JSON?

[drazisil]

The content can be a mix of things, not just JSON. It can be XML, text, JSON, etc. Any format that a coverage report can be in, and often serveral types in the same gzip. What would you propose in this case?

[drazisil]

Actually, I misspoke. The content is always text. What indicates to you that it is JSON?

[RA80533]

Simply based on that comment. If it's actually just a stream of text, line 41 and 69 should be changed to text/plain.

[drazisil]

Got it. Thank you for explaining, @RA80533 :)