Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Preserve LF in the report file names list #413

Conversation

webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Oct 6, 2021

Fixes #411

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #413 (de90af1) into master (b47887c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
- Coverage   92.43%   92.41%   -0.03%     
==========================================
  Files          27       27              
  Lines         899      896       -3     
  Branches      175      175              
==========================================
- Hits          831      828       -3     
  Misses         28       28              
  Partials       40       40              
Flag Coverage Δ
alpine 92.41% <100.00%> (∅)
linux 92.41% <100.00%> (?)
linux-without-git 92.41% <100.00%> (-0.03%) ⬇️
macos 92.41% <100.00%> (?)
macos-without-git 92.41% <100.00%> (-0.03%) ⬇️
windows 92.41% <100.00%> (∅)
windows-without-git 92.41% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/files.ts 94.20% <100.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47887c...de90af1. Read the comment docs.

@webknjaz
Copy link
Contributor Author

webknjaz commented Oct 6, 2021

@mitchell-codecov if you decide to go for #412, feel free to drop this PR.

@drazisil-codecov drazisil-codecov added the hacktoberfest-accepted This PR should qualify for Hacktoberfest credit label Oct 6, 2021
@drazisil-codecov drazisil-codecov changed the title 🐛 Preserve LF in the report file names list fix: 🐛 Preserve LF in the report file names list Oct 6, 2021
Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mitchell-codecov
Copy link
Contributor

Thanks for the PR, @webknjaz! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted This PR should qualify for Hacktoberfest credit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v0.1.4 regression] The file list in the uploaded reports is squashed
3 participants