Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libstorage.host required in configuration even when defined under modules #827

Closed
cduchesne opened this issue May 2, 2017 · 0 comments
Closed
Assignees
Milestone

Comments

@cduchesne
Copy link
Contributor

When testing modules, I noticed that libstorage.host is required at root of config even if also defined under defined modules.

# cat /etc/rexray/rexray-agent.yml
rexray:
  modules:
    default-docker:
      type: docker
      desc: default docker module
      host: unix:///run/docker/plugins/rexray1.sock
      libstorage:
        host: tcp://10.50.0.10:7979
        service: scaleio
    rexray2-module:
      type: docker
      desc: second module
      host: unix:///run/docker/plugins/rexray2.sock
      libstorage:
        host: tcp://10.50.0.20:7979
        service: scaleio2
ERRO[0000] default module(s) failed to initialize        error=libStorage host config missing time=1493682067471
@codenrhoden codenrhoden added this to the 2017.06-1 milestone May 30, 2017
@akutz akutz self-assigned this Jun 1, 2017
akutz added a commit to akutz/rexray that referenced this issue Jun 7, 2017
This patch fixes rexray#827 where a libStorage host may not be defined at the
root of a configuration but instead scoped to a module. With this patch
if host detection fails (root configuration / running, local host) when
initializing the module subsystem a warning is logged and the modules
themselves must explicitly define the host to which to connect.

This patch does *not* support starting a new host from a module-scoped
host definition. The module-scoped host properties are for overriding
the host to which to connect only.
akutz added a commit to akutz/rexray that referenced this issue Jun 7, 2017
This patch fixes rexray#827 where a libStorage host may not be defined at the
root of a configuration but instead scoped to a module. With this patch
if host detection fails (root configuration / running, local host) when
initializing the module subsystem a warning is logged and the modules
themselves must explicitly define the host to which to connect.

This patch does *not* support starting a new host from a module-scoped
host definition. The module-scoped host properties are for overriding
the host to which to connect only.
akutz added a commit to akutz/rexray that referenced this issue Jun 7, 2017
This patch fixes rexray#827 where a libStorage host may not be defined at the
root of a configuration but instead scoped to a module. With this patch
if host detection fails (root configuration / running, local host) when
initializing the module subsystem a warning is logged and the modules
themselves must explicitly define the host to which to connect.

This patch does *not* support starting a new host from a module-scoped
host definition. The module-scoped host properties are for overriding
the host to which to connect only.
@akutz akutz closed this as completed Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants