Replace node-sass with dart-sass #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'sass' is the new pure-js "drop in replacement" for 'node-sass' - update emitDependencies to not emit the "starting" file (seems like node-sass was avoiding it, but new sass includes it) - update tests to fix path comparison logic on windows - new 'sass' doesn't seem to have consistent support for custom importers, so after fighting with it for a bit I decided to just kill support for that since we aren't using it in Code Dx. - Add package-lock.json to the gitignore, since apparently it's not supposed to be used for libraries / can't be published with npm - Add .idea/ to the gitignore, since I'm using IntelliJ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an indirect dependency on node-sass (via scssify), which is now deprecated, not to mention giving us issues where we were stuck with overly-specific node/npm versions. This branch is mainly to replace node-sass with https://www.npmjs.com/package/sass within scssify.
I touched a couple tests so that they would pass on my machine (I'm on windows, where path comparisons are kinda screwy).
I also dropped support for "custom importers" due to a lack of need for them for our use case, and due to sass/dart-sass#574 which means that the underlying support is behaving differently than it did with node-sass.
I'm making this PR as just a draft, since I don't expect to be able to merge this into the main scssify, and I want to be able to easily find this again without having to remember the branch name or commit hash. No need to actually merge this, at least for now.