Skip to content
This repository has been archived by the owner on Nov 27, 2022. It is now read-only.

Need APNS abstraction layer #191

Merged
merged 6 commits into from
Jun 25, 2014
Merged

Need APNS abstraction layer #191

merged 6 commits into from
Jun 25, 2014

Conversation

mallowlabs
Copy link
Member

I want to switch APNS engine. For example,

  • Embed (currently this)
  • ZeroPush
  • Parse
  • Helios

So we need APNS abstraction layer to AsakusaSatellite.

@mallowlabs mallowlabs changed the title Need APNS abstraction layer [WIP]Need APNS abstraction layer Jun 24, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) when pulling c1ee22c on mallowlabs:id/191 into c0fe7f5 on codefirst:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling 15c58e5 on mallowlabs:id/191 into c0fe7f5 on codefirst:master.

@mallowlabs mallowlabs changed the title [WIP]Need APNS abstraction layer Need APNS abstraction layer Jun 25, 2014
def self.register_callback(event)
class_eval <<-EOS
@@#{event.to_s}_procs = []
def self.add_#{event.to_s}(proc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use def self.add_#{event.to_s}(&proc).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.95%) when pulling abc4f26 on mallowlabs:id/191 into c0fe7f5 on codefirst:master.

@mzp
Copy link
Member

mzp commented Jun 25, 2014

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.96%) when pulling 84df6fa on mallowlabs:id/191 into c0fe7f5 on codefirst:master.

mallowlabs added a commit that referenced this pull request Jun 25, 2014
Need APNS abstraction layer
@mallowlabs mallowlabs merged commit dd424eb into codefirst:master Jun 25, 2014
@mallowlabs mallowlabs deleted the id/191 branch June 25, 2014 14:54
@mallowlabs
Copy link
Member Author

Thanks for your 🍣

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants