fix bug: GithubController#hook

codefirst · May 2, 2014 · 7efee06 · 7efee06
1 parent ff65d51
commit 7efee06
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/controllers/github_controller.rb b/app/controllers/github_controller.rb
@@ -40,7 +40,7 @@ def import(url)
       owner, repos = commit.project.split('/', 2)
       project = Project.where(owner: owner, repos: repos).first_or_create!
 
-      project.users << current_user
+      project.users << current_user if current_user
 
       # update other attributes
       rev.update_attributes(commit.to_h.merge(project: project))

diff --git a/spec/controllers/github_controller_spec.rb b/spec/controllers/github_controller_spec.rb
@@ -111,7 +111,9 @@ def commit(opt)
       before do
         RevisionIt::Service::Github.
           stub(:commits).
-          with('https://example.com')
+          with('https://example.com').
+          and_yield(commit(hash_code: "foo", url: "http://example.com", log: "this is text")).
+          and_yield(commit(hash_code: "bar", url: "http://example.com", log: "this is text", project: "mzp/hoge" ))
 
         post 'hook', payload: { repository: { url: 'https://example.com' } }.to_json
       end