Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix html structure #137

Merged
merged 2 commits into from
Jan 21, 2015
Merged

Fix html structure #137

merged 2 commits into from
Jan 21, 2015

Conversation

techieshark
Copy link
Contributor

@vancefsmithmesa pointed out that the html structure was wrong (top bar and footer outside of <body>); this fixes that.

Fixes #132, fixes #133.

@vancefsmithmesa
Copy link
Contributor

Thanks Peter!

For the life of me I cannot figure out how to merge the changes you made into our fork. Please help. Any googling I do on the subject only shows command line options. I want to do this directly on GitHub.com

Vance F Smith | IT Engineer III | Information Technology | O: 480-644-3243

From: Peter W [mailto:notifications@github.com]
Sent: Friday, January 09, 2015 5:10 PM
To: codeforamerica/MuniciPal
Cc: Vance Smith
Subject: [MuniciPal] Fix html structure (#137)

@vancefsmithmesahttps://github.com/vancefsmithmesa pointed out that the html structure was wrong (top bar and footer outside of ); this fixes that.

Fixes #132#132, fixes #133#133.

You can merge this Pull Request by running

git pull https://github.com/codeforamerica/MuniciPal fixes/132-133-html-structure

Or view, comment on, or merge it at:

#137

Commit Summary

  • move footer and topbar inside
  • move topbar into its own file

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/137.

techieshark added a commit that referenced this pull request Jan 21, 2015
@techieshark
Merge pull request #137 from codeforamerica/fixes/132-133-html-structure
caa6df4 
Fix html structure
@techieshark techieshark merged commit caa6df4 into master Jan 21, 2015
@techieshark techieshark deleted the fixes/132-133-html-structure branch January 21, 2015 23:04
@vancefsmithmesa vancefsmithmesa mentioned this pull request Jan 22, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@techieshark @vancefsmithmesa