Resolves Accessibility issue at expense of design #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @analoo I'm a little confused. Is this for ticket: https://www.pivotaltracker.com/story/show/187155006? The page you show above is the ChoosePrograms page. |
spokenbird
reviewed
Apr 17, 2024
| @@ -8,7 +8,7 @@ | |||
| <button class="accordion__button" aria-expanded="true" aria-controls="controlId"> | |||
| <th:block th:replace="${buttonLabel}"/> | |||
| </button> | |||
| <div class="accordion__content" id="controlId"> | |||
| <div class="accordion__content" aria-expanded="false" id="controlId"> | |||
There was a problem hiding this comment.
This needs to get updated by JavaScript (which I believe Honeycrisp does automatically?) or it won't work with screen readers.
Let me know if you wanna pair on testing it :)
|
What issue is the being resolved? Not sure what the screenshot is showing 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ariaLabels in a few screens where the screen reader is having a hard time finding appropriate content to associate with questions.