Add pages for intro to system and choosing programs #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseeger
commented
Jan 31, 2024
| th:replace="~{fragments/inputs/checkboxInSet :: checkboxInSet(inputName='programs',value='SNAP', label=#{choose-programs.snap}, checkboxHelpText=#{choose-programs.snap-help})}"/> | ||
| <th:block th:each="programType : ${T(org.mdbenefits.app.data.enums.ProgramType).values()}"> | ||
| <th:block th:if="${fieldData.get('helpNeeded[]').contains(programType.name())}"> | ||
| <span th:with="shortDesc=${programType.getShortDescSrc().isBlank()} ? '' : #{${programType.getShortDescSrc()}}" |
There was a problem hiding this comment.
The one place where this PR deviates from the design is the styling of the help text in the select boxes on the Choose Program page. The color is wrong and I could not easily figure out how to change it.
vrajmohan
reviewed
Jan 31, 2024
src/main/java/org/mdbenefits/app/data/enums/ApplicationDescriptionType.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mdbenefits/app/data/enums/ApplicationDescriptionType.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mdbenefits/app/submission/conditions/ShouldRedirectToMDThink.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mdbenefits/app/submission/conditions/ShouldRedirectToMDThink.java
Outdated
Show resolved
Hide resolved
| @@ -1,5 +1,5 @@ | |||
| # Overrides | |||
| general.inputs.continue=Continue | |||
| general.inputs.continue=Next | |||
There was a problem hiding this comment.
It would be better to change to general.inputs.next everywhere, but that is a bigger change. This is why I asked Design about the need for this.
There was a problem hiding this comment.
This does change the value displayed for any continue button to Next anywhere it's found in the system. Are you suggesting something different here?
src/main/resources/templates/mdBenefitsFlow/redirectToMDThink.html
Outdated
Show resolved
Hide resolved
src/test/java/org/mdbenefits/app/journeys/MdBenefitsFlowJourneyTest.java
Outdated
Show resolved
Hide resolved
bseeger
commented
Jan 31, 2024
This also tweaks the county setup to include the value of what the enum represents, versus the name of the enum, which would be harder to look up later. Starts to outline the redirectToMDThink page, but that's a wip.
This also cleans up the code a little.
Swaps order of County and Select Application pages (per design changes). Changes ApplicationDescriptionType enum to ApplicantObjectives. Removes OHEP option (comments it out) Fixes link in myMDTHINK redirect.
bseeger
force-pushed
the
add_select_application_186922235
branch
from
1157d4a
to
101132e
Compare
Some general cleanup and updates the values used in the application selection and help needed page to be the enum page. Also updates the county page to store the enum name as well, versus county string.
|
Data now looks like this: Another example: |
Adds in checkboxFieldset & checkboxInSet to our fragments so we can override them. This part is not done yet, but should be part of another set of pages. (was outside of scope of this PR)
|
For the choose program page -- it will change again, so don't focus on comparing that part so much to design. That page was out of scope for this work, but I added it so the data would be there for the sign & submit part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also tweaks the county setup to include the value of what the enum represents, versus the name of the enum, which would be harder to look up later.
This will redirect users to MDTHINK if they are outside of select counties, or if they have a need the website is not built for.
@vrajmohan - A side effect of this PR is that it will change all "Continue" buttons to "Next", thereby addressing the issue you were seeing with the doc uploader screens.