[PAIR] Specify members to populate many members steps #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously, ManyMembersStepsController had to check if attributes were present, because there were times where only specific members populate a form, but when assigning attributes, it uses all members in application * No steps using ManyMembersStepsController have fields in the application, just on members, so no need to merge attributes * Remove some unused attributes from steps [#153526809 Signed-off-by: Paras Sanghavi <paras@codeforamerica.org>
luigi
changed the title
|
@hartsick @jessieay @bengolder Check out this PR! It's a small but significant change to the way we're handling many member steps. Less conditionals in shared code! |
|
this is rad— |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManyMembersStepsControllerhad to check if attributeswere present, because there were times where only specific members
populate a form, but when assigning attributes, it uses all members in
application
ManyMembersStepsControllerhave fields in theapplication, just on members, so no need to merge attributes
[#153526809]
Signed-off-by: Paras Sanghavi paras@codeforamerica.org