Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hour/minute timestamp to incoming requests #172

Open
cydharrell opened this issue Mar 16, 2015 · 1 comment
Open

add hour/minute timestamp to incoming requests #172

cydharrell opened this issue Mar 16, 2015 · 1 comment

Comments

@cydharrell
Copy link

This is important because of how the clock starts for the legally required response period. A request received by 5pm is counted as entered that day, while a request received at 7 is not counted as "in" until the next business day. Because the legal response time is in calendar days, counting a 7pm Friday request as "Friday" can lose a responding agency days of time and put them in rush mode or cause them to be out of compliance.

@cydharrell cydharrell added this to the legal language and dates milestone Mar 16, 2015
mjumbewu added a commit that referenced this issue May 20, 2015
This, along with commits 7a9b0ac and 9c420e7 should at least partially resolve
issue #172 as I undersand it. I think the problem is that the requested dates
weren't being displayed, even though they were stored in the database.

There is another side to the story: The due_date may still report a premature
overdue status, because it's set relative to the date_created. The set_due_date
method is going to have to become smarter to take into account the time of day
that the request was made.
mjumbewu added a commit that referenced this issue May 20, 2015
This, along with commits 7a9b0ac and 9c420e7 should at least partially resolve
issue #172 as I undersand it. I think the problem is that the requested dates
weren't being displayed, even though they were stored in the database.

There is another side to the story: The due_date may still report a premature
overdue status, because it's set relative to the date_created. The set_due_date
method is going to have to become smarter to take into account the time of day
that the request was made. For now, displaying the time at least allows users
to spot check whether the request is ACTUALLY overdue.
@mjumbewu
Copy link
Member

Commits ef33cd7, 7a9b0ac, and 9c420e7 at least partially resolve this as I understand it. The times were being stored in the database, but they were not being displayed.

Those commits do not fix the fact that the due_date may still report a premature overdue status, because it's set relative to the date_created. The set_due_date method is going to have to become smarter to take into account the time of day that the request was made. For now, displaying the time at least allows users to spot check whether the request is actually overdue.

joelbcastillo referenced this issue in CityOfNewYork/NYCOpenRecords Jan 4, 2016
OP-447: security fixes
joelbcastillo referenced this issue in CityOfNewYork/NYCOpenRecords Mar 2, 2017
task/OP-1050: Fixed Tooltip wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants