Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fyst 133 state code from intake first #4598

Merged
merged 10 commits into from
Jun 18, 2024

Conversation

jenny-heath
Copy link
Contributor

@jenny-heath jenny-heath commented Jun 17, 2024

Link to pivotal/JIRA issue

Is PM acceptance required?

  • No

What was done?

  • added method to state file questions controller current_state_code which first tries to get US state from current_intake and, if not there, checks params
  • replace all uses of params[:us_state] that A) should be checking the intake first and B) have access to the helper method
  • replace some lines where display name of state is derived from States or whatever and instead use state_name helper from questions controller
  • rename some local variables so they don't show up in search for state_code

How to test?

  • One added test for the helper method
  • The goal is for it to work the same so if all the tests pass we should (should) be good

Copy link

Heroku app: https://gyr-review-app-4598-9b5d76ed6a28.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4598 (optionally add --tail)

@jenny-heath jenny-heath merged commit bb78b7b into main Jun 18, 2024
7 checks passed
@jenny-heath jenny-heath deleted the FYST-133-state-code-from-intake-first branch June 18, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants