Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fyst 133 state code from intake first #4598

Merged
merged 10 commits into from
Jun 18, 2024
Merged

Fyst 133 state code from intake first #4598

merged 10 commits into from
Jun 18, 2024

Commits on Jun 14, 2024

  1. Add method to get state code from current intake first, then params; … 

    …replace references to old state_code method with current_state_code
    @jenny-heath
    jenny-heath committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    984c7ed View commit details
    Browse the repository at this point in the history

  2. fix infinite loop :/

    @jenny-heath
    jenny-heath committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2e50ec4 View commit details
    Browse the repository at this point in the history

  3. replace references to params[:us_state] with current_state_code

    @jenny-heath
    jenny-heath committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    3b38256 View commit details
    Browse the repository at this point in the history

  4. oops

    @jenny-heath
    jenny-heath committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    dc5d5ea View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. oops i guess i didn't fix the merge conflict good (but also there wer… 

    …e other problems)
    @jenny-heath
    jenny-heath committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    62f2ad6 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. change back state code source in question_navigator

    @jenny-heath
    jenny-heath committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4a0640c View commit details
    Browse the repository at this point in the history

  2. Remove check that state code from params is valid: if invalid will re… 

    …sult in a 404 before this code is ever reached
    @jenny-heath
    jenny-heath committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8e6958c View commit details
    Browse the repository at this point in the history

  3. remove comments, refactor

    @jenny-heath
    jenny-heath committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    075436d View commit details
    Browse the repository at this point in the history

  4. Resurrect StateFile::StateFileControllerConcern, put current_intake +… 

    … state_name + current_state_code + current_tax_year in there
    @jenny-heath
    jenny-heath committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    e4f37b6 View commit details
    Browse the repository at this point in the history

  5. rename StateFileControllerConcern#state_name to current_state_name

    @jenny-heath
    jenny-heath committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    b0d65d6 View commit details
    Browse the repository at this point in the history