Address bug #74
Open
Address bug #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 22, 2016 18:55
…oting_locations into map-sidebar-interaction
carpeliam
reviewed
Oct 28, 2016
| var collapsedToggle = Boolean(document.getElementById('#collapse-toggle'+i).getAttribute("aria-expanded")); | ||
|
|
||
| if (collapsedToggle) { | ||
| $('#collapse'+i).collapse('show'); |
There was a problem hiding this comment.
with some of the work that @WheresHJ did on the design, I'm not sure if we want to do this (as some of the most important information will be displayed in the collapsed state) - I'm going to cherry-pick the commit for the address change to pull that in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #71
changed isStreetAddress to isNotPOx