Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UnionYears in user-state-manager to utilize yet unspecified retirement date #264

Open
2 tasks
thadk opened this issue Feb 3, 2021 · 0 comments
Open
2 tasks

Fix UnionYears in user-state-manager to utilize yet unspecified retirement date #264

thadk opened this issue Feb 3, 2021 · 0 comments

Comments

@thadk
Copy link
Member

thadk commented Feb 3, 2021

  • move the default value for retireDate from user-state-context to this function (?) so that it can see when the retire date is yet unset. Right now, it is impossible to know whether it is the starting value. This may require other changes to support the new default value of retire date.
  • Use some of the code in the comments from user-state-manager.tsx line 94 and also inline comments to utilize whether retireDate had previously been set.
dmeegan pushed a commit to dmeegan/windfall-elimination that referenced this issue Mar 3, 2021
@djmVHB
fix MergeYears to accept retireDate passed codeforboston#264
87031d0
@dmeegan dmeegan mentioned this issue Mar 3, 2021
Open
dmeegan pushed a commit to dmeegan/windfall-elimination that referenced this issue Mar 3, 2021
@djmVHB
set up MergeYears comparisons codeforboston#264
8a9ac23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thadk