Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor _populate_zone_facts to be cleaner #563

Open
NealHumphrey opened this issue Sep 19, 2017 · 0 comments
Open

Refactor _populate_zone_facts to be cleaner #563

NealHumphrey opened this issue Sep 19, 2017 · 0 comments
Assignees
@pfjel7
Labels
low-priority post-launch Python

Comments

@NealHumphrey
Copy link
Collaborator

The _populate_zone_facts method and its related methods were carried over from the API, which needed to calculate specific zone information on demand using user inputs. Now we are calculating all the zone_facts ahead of time and caching them in the zone_facts table. As such, a lot of the structure that was needed for an on-demand calculation is no longer as understandable and is more complicated than needed.

Refactor this section of the code to cleanly calculate all the zone facts statistics and pay down our tech debt on this section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfjel7 pfjel7

Labels
low-priority post-launch Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NealHumphrey @pfjel7