New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined ApiConn pull requests #286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… database instead of a file
…esults_to_csv from base class and adding optional parameters to choose which database to use (still working on that)
…same. changed wmata_distcalc.py so that the headers match that
…ent method that will play well with our future need to run all the api classes automatically.
… classes through their get_data method. - A few edits to the DCHousing class to get it to work with the current system (rename method and switch to use consistent params as other get_data methods)
@emkap01 Heads up that when this PR is approved it means that the crime, building permits, and tax data sets are all done with the 'write api code' step and need to move on to the 'cleaner/ingestion' part of the process. |
3 tasks
…ethod - updated the get_data signature to include a **kwargs so that any additional arguments only needed by some apiconn objects can be ignored by others (e.g. database choice `db`) - Some general cleanup of wmataapiconn as noted in the code review.
Closed
jkwening
approved these changes
May 23, 2017
👍 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request combines code from #278, #283, and #284, and then adds on to it to standardize the method signature of the ApiConn classes. It also replaces the get_api_data.py with a new approach. This resolves issues #274, #187, #260, and #198. Issue #16 is included but still outstanding because we are waiting to find out when opendata.dc.gov will update their 2017 building permits data set.
Overview of changes in this PR:
@property
calledoutput_paths
that returns a dictionary ofunique_data_id:absolute_local_output_filepath
for all the _available_unique_data_ids. This automatically builds in datestamping.get_data()
method. It should be able to run without any mandatory parameters, and it must contain the following (user) optional params: unique_data_ids (to allow for flexibility of not always downloading all data sets),sample
(for easier testing by downloading only a few rows), andoutput_type
(normally should be 'csv' but can be 'stdout').@jkwening Can you review this?
@ajhalani Check this out, maybe you can do a code review as well? It doesn't look like it because I had to rewrite a bunch of stuff so to work with the new approach to get_api_data.py but your code was a very useful influence.