-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flowdock and GitHub usernames #45
Conversation
src/UserInfo.js
Outdated
|
||
updateDB() { | ||
const { githubName, flowdockName, description } = this.state; | ||
const { id } = this.props.data.user; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optionally destructure on the right hand side...
const { data: { user : { id } } = this.props;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but totally up to you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comment/suggestion LGTM 👏
Thanks @jksmall0631 !
src/LoginAuth0.js
Outdated
@@ -51,12 +53,18 @@ class LoginAuth0 extends Component { | |||
const idToken = window.localStorage.getItem( | |||
"cfd-members-auth0IdToken" | |||
); | |||
let nickname = ""; | |||
let { identities: [ { provider} ] } = profile; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space, NBD though
This PR closes #25 and closes #35 and closes #44
What does this PR do?
-created inputs for usernames
-modified user update mutation
-display user info in inputs if available
How does this PR make you feel? 🔗