Add Flowdock and GitHub usernames #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dviramontes
reviewed
Sep 15, 2017
src/UserInfo.js
Outdated
|
|
||
| updateDB() { | ||
| const { githubName, flowdockName, description } = this.state; | ||
| const { id } = this.props.data.user; |
There was a problem hiding this comment.
optionally destructure on the right hand side...
const { data: { user : { id } } = this.props;
dviramontes
approved these changes
Sep 15, 2017
There was a problem hiding this comment.
Other than the comment/suggestion LGTM 👏
Thanks @jksmall0631 !
dviramontes
reviewed
Sep 15, 2017
src/LoginAuth0.js
Outdated
| @@ -51,12 +53,18 @@ class LoginAuth0 extends Component { | |||
| const idToken = window.localStorage.getItem( | |||
| "cfd-members-auth0IdToken" | |||
| ); | |||
| let nickname = ""; | |||
| let { identities: [ { provider} ] } = profile; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #25 and closes #35 and closes #44
What does this PR do?
-created inputs for usernames
-modified user update mutation
-display user info in inputs if available
How does this PR make you feel? 🔗