Add error logging to project #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolkheang
reviewed
Jul 24, 2018
tagging_tracker/settings.py
Outdated
| }, | ||
| 'file': { | ||
| 'class': 'logging.FileHandler', | ||
| 'filename': '/logs/error.log' |
There was a problem hiding this comment.
Does this need to have the prefix /code/ path?
kolkheang
approved these changes
Jul 24, 2018
tagging_tracker/settings.py
Outdated
| 'loggers': { | ||
| '': { # 'catch all' loggers by referencing it with the empty string | ||
| 'handlers': ['console', 'file'], | ||
| 'level': 'DEBUG', |
There was a problem hiding this comment.
Can you use the variable debug above?
There was a problem hiding this comment.
if DEBUG is true, set to 'DEBUG' else, set to info?
https://github.com/codeforkansascity/tagging_tracker_backend/pull/43/files#diff-5fbc47b4c304f27a99656b4293e9c029R23
There was a problem hiding this comment.
I think that when we launch this, we would want the error logging on the server so we can have some insight if something goes wrong. If you want me to change that, I can.
There was a problem hiding this comment.
Okay, I'll add a logging level configuration.
It is difficult to debug an application that does not produce any erorr logging. Add error logging to project through an error file and console output. Signed-off-by: Frederick Lawler <fred@fredlawl.com>
Developers should be able to configure their log level for development. Add a note to the README with updated documentation concerning the new setting, and add the setting to the settings.py file with a default of ERROR if unspecified. Signed-off-by: Frederick Lawler <fred@fredlawl.com>
kolkheang
approved these changes
Jul 24, 2018
fredlawl
added a commit
to fredlawl/tagging_tracker_backend
that referenced
this pull request
Oct 30, 2018
d41e6f1 ("Merge pull request codeforkansascity#43 from fredlawl/issue-42") addressed an issue where there was need to have error logging in the project. A bug was introduced such that the log directory did not exists when Django operations are ran via ssh-ing into the container. This problem also exists for people who perform operations without the Docker build process. Fix this by adding in a logs directory into the project root, and modify the Docker startup script to create the files/directories before Django build processes runs. Signed-off-by: Frederick Lawler <fred@fredlawl.com>
fredlawl
added a commit
to fredlawl/tagging_tracker_backend
that referenced
this pull request
Nov 4, 2018
d41e6f1 ("Merge pull request codeforkansascity#43 from fredlawl/issue-42") addressed an issue where there was need to have error logging in the project. A bug was introduced such that the log directory did not exists when Django operations are ran via ssh-ing into the container. This problem also exists for people who perform operations without the Docker build process. Fix this by adding in a logs directory into the project root, and modify the Docker startup script to create the files/directories before Django build processes runs. Signed-off-by: Frederick Lawler <fred@fredlawl.com>
fredlawl
added a commit
that referenced
this pull request
Nov 20, 2018
d41e6f1 ("Merge pull request #43 from fredlawl/issue-42") addressed an issue where there was need to have error logging in the project. A bug was introduced such that the log directory did not exists when Django operations are ran via ssh-ing into the container. This problem also exists for people who perform operations without the Docker build process. Fix this by adding in a logs directory into the project root, and modify the Docker startup script to create the files/directories before Django build processes runs. Signed-off-by: Frederick Lawler <fred@fredlawl.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is difficult to debug an application that does not produce any erorr
logging. Add error logging to project through an error file and
console output.
Signed-off-by: Frederick Lawler fred@fredlawl.com