Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new/current local bodies name at TopoJSON and GeoJSON file #96

Closed
nikeshbalami opened this issue Dec 22, 2019 · 6 comments
Closed
Labels
dependencies Pull requests that update a dependency file

Comments

@nikeshbalami
Copy link
Collaborator

Find a way to update new/current local levels name at TopoJSON and GeoJSON file, so that the new name can be displayed at a map while hovering.

Here is the list of the changed local bodies name: https://docs.google.com/spreadsheets/d/1Y3Na_CEWLHERczUng_lGfpc4jl0qalVAmF3Aioc6VEc/edit?usp=sharing

@nikeshbalami nikeshbalami added the dependencies Pull requests that update a dependency file label Dec 22, 2019
@nikeshbalami
Copy link
Collaborator Author

I believe the name of local bodies in Map are still needed to be made as per the above sheet. In #95 (comment) @cliftonmcintosh suggested writing a script to alert the changed name, rather than changing the whole GEO file.

@pratimakandel @ishandongol do you guys know how to do it, or maybe @cliftonmcintosh if you have some time this weekend, can you help to resolve this issue.

Once this issue is resolved, we can confidently make the site public for the review.

@cliftonmcintosh
Copy link
Member

@nikeshbalami

Thanks for the update. My available time is limited right now, and I will be unable to help with this task. @Crackjack did the initial work to add the geo codes and names to the JSON files. He may have a script that can be adapted for this work.

@openrijal
Copy link
Collaborator

Hi Guys. The script I used are still available here: https://github.com/Code4Nepal/maptools/tree/master/geo

Let me know if I can be of any help.

@openrijal
Copy link
Collaborator

openrijal commented Jan 5, 2020

I would suggest a quick find and replace in this case. Writing a script might be longer than doing it manually.

@pratimakandel
Copy link
Collaborator

I have created a pull request for this issue, Please let me know if there is anything missing.
#99

cliftonmcintosh added a commit that referenced this issue Jan 12, 2020
Issue (#96)  Update new/current local bodies name at TopoJSON and GeoJSON file
@nikeshbalami
Copy link
Collaborator Author

Closing this issue, solved by PR #99

Thank you @pratimakandel :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

4 participants