mapbox templates #35
Merged
mapbox templates #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // } | ||
| // | ||
| // | ||
| // |
There was a problem hiding this comment.
Should this comment block be removed?
There was a problem hiding this comment.
+2 for implementing commented code
|
Are the *.html templates required? They appear to be unused. |
…ja2 will need to implement its own on document ready
|
|
||
| call_map = [["cases", "/cases"],["hoa", "/hoas"]]; | ||
|
|
||
| _fn = function(value) { |
There was a problem hiding this comment.
Can this be a more descriptive function name?
|
Ironically, I had a lot more comments about your JS than your python. 👅 The only blocker here is the fix for Firefox, I think. But we can file a follow-up issue for it instead if it's not a quick fix. |
|
Yay - works great! Can you go thru the issues now and close all the ones that are closed by the PR? |
This was referenced Sep 7, 2014
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.