Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time evaluation step status updates for client #714

Merged
merged 9 commits into from Jan 11, 2021

Conversation

HenningCash
Copy link
Member

@HenningCash HenningCash commented Dec 17, 2020

📢 Type of change

  • New feature (non-breaking change which adds functionality)

📜 Description

Because evaluation steps are now run in parallel we can give the user immediate feedback if the step has finished. This PR pushes the new status to the client.

I used this to refactor a lot of client-side code (and some of the subscription API):

  • To watch an evaluation for an answer there is now a single subscription evaluationStatusUpdated that will push changes either for all evaluations of a user or for a single answer.
  • I moved A LOT of components from the EvaluationResult page to their own component
  • GraphQL fragments now have their own directory

🔗 Related Issues

  • Fixes # (issue)

☑️ Checklist:

  • I have performed a self-review of my own code
  • I have run the auto code formatting scripts
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I updated the CHANGELOG.md
  • I have added tests that prove my fix is effective or that my feature works

@HenningCash HenningCash marked this pull request as ready for review January 7, 2021 17:41
erikhofer
erikhofer previously approved these changes Jan 11, 2021
@HenningCash HenningCash merged commit 47b414c into master Jan 11, 2021
@HenningCash HenningCash deleted the feature/push-evaluation-step-status branch January 11, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants