Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor caching and subscriptions for evaluations #814

Merged
merged 2 commits into from Feb 18, 2021

Conversation

HenningCash
Copy link
Member

馃摙 Type of change

  • Bug fix (non-breaking change which fixes an issue)

馃摐 Description

I hope this will fix all remaining issues with client-side cached evaluations.

  • Invalidate cached latest evaluation after starting evaluation
  • Use subscribeToMore of query results instead of standalone subscriptions + useEffect where possible
  • Dropped initial data from useLatestEvaluation hook. This was used for the Submission Table. Instead the submission table now only subscribes for evaluation updates.

鈽戯笍 Checklist:

  • I have performed a self-review of my own code
  • I have run the auto code formatting scripts
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I updated the CHANGELOG.md
  • I have added tests that prove my fix is effective or that my feature works

@HenningCash
Copy link
Member Author

Need to add unsubscribe

@HenningCash
Copy link
Member Author

nvm. unsubscribe of subscribeToMore is correctly handled by Apollo

@HenningCash HenningCash reopened this Feb 12, 2021
@erikhofer erikhofer merged commit 9bbe209 into master Feb 18, 2021
@erikhofer erikhofer deleted the fix/evaluation-caching branch February 18, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants