Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to semantic versions #88

Closed
dirien opened this issue Sep 5, 2022 · 2 comments · Fixed by #90
Closed

Switch to semantic versions #88

dirien opened this issue Sep 5, 2022 · 2 comments · Fixed by #90
Labels
automation bug Something isn't working

Comments

@dirien
Copy link

dirien commented Sep 5, 2022

Hi,

It would be nice, if this repo would switch to semantic versions, so we can use this repo as go module -> https://go.dev/blog/publishing-go-modules

Every required module in a go.mod has a [semantic version](https://semver.org/), the minimum version of that dependency to use to build the module.

A semantic version has the form vMAJOR.MINOR.PATCH.

Currently, I get following error message:

go get github.com/codefresh-io/terraform-provider-codefresh@0.0.24
go: github.com/codefresh-io/terraform-provider-codefresh@v0.0.24: reading github.com/codefresh-io/terraform-provider-codefresh/go.mod at revision v0.0.24: unknown revision v0.0.24
@korenyoni
Copy link
Contributor

Hi @dirien, I am currently looking at a larger release automation overhaul which addresses this also. See my personal fork: korenyoni#1

I am discussing this internally with previous maintainers of this repo, and I will link a PR to this issue, alongside other issues.

@dirien
Copy link
Author

dirien commented Sep 12, 2022

Ah oky @korenyoni, than I should wait with the Pulumi provider, I started here -> https://github.com/dirien/pulumi-codefresh

Thanks for the feedback and letting me in the loop!

@korenyoni korenyoni added bug Something isn't working automation labels Sep 14, 2022
@korenyoni korenyoni mentioned this issue Sep 28, 2022
Merged
korenyoni added a commit that referenced this issue Oct 3, 2022
@korenyoni
Feat: Pipeline Cron Trigger (#90)
c14eb01 
## What

* Add resource for Pipeline Cron Trigger
* Fix Terraform Acceptance tests
* Add Acceptance Tests to CI
* Add release automation (release drafter, labeler, automatic changelog
drafting)
* GH Repo best practices (PULL_REQUEST_TEMPLATE, CODEOWNERS, etc)
* Misc documentation fixes

## Why

* Only git triggers are currently supported.
* Triggers should be a standalone resource. The next minor release
(`0.2.0`) will support remaining standalone triggers (registry, helm,
git).

## Notes

* Closes #39 
* Closes #88
* #84

Co-authored-by: Yonatan Koren <10080107+korenyoni@users.noreply.github.com>
Co-authored-by: korenyoni <korenyoni@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Pipeline Cron Trigger korenyoni/terraform-provider-codefresh
2 participants
@korenyoni @dirien