-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Bagdes by Tags in Card props #164
Comments
Sorry we read a little too fast. So it seems that both tags and badges are possible but not at the same time. We would like to have the possibility to choose from tags or badges. We thought of something like this: changing the following prop |
@ocruze Seems fine to me. Do you plan to work on this? |
I got some new elements from DSFR UX/UI.
|
Hi @slafayIGN, thank you for bringing those rules to my attention. If I understand correctly, you're saying that the current Card component allows usages that don't adhere to the official DSFR guidelines. Is that correct? Should the component be completely overhauled? |
feat(Card)!: update component to match dsfr guidelines (refs #164)
In the documentation of dsfr (https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/carte) it's already tags instead of badges.
So we should apply changes to Card component
I can work on a PR
The text was updated successfully, but these errors were encountered: