feat(Card)!: update component to match dsfr guidelines (refs #164) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* only one badge in the image area * update storybook
ocruze
changed the title
slafayIGN
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Thank you @ocruze
I would like to add that most issues mentioned in #164 comments regarding conformity with the DSFR are not enforced with this PR but the documentation and examples are more accurate and show more use cases. One example with badges in both the image and the content areas has been modified because it was not permitted.
The start prop ends up being enough for the tags group or badges group in the content, without adding more complexity to the component.
|
Thanks a lot, I'll be reviewing that |
|
Merged! Thank you for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #164
! BREAKING CHANGE !
badgesbecomesbadge)