Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional title for alert components #138

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

sutter
Copy link
Contributor

@sutter sutter commented Jun 8, 2023

Remove empty title tags in small size components when the title is not provided.
CleanShot 2023-06-08 at 10 51 44 2@2x

Copy link
Collaborator

@garronej garronej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good catch!

src/Alert.tsx Outdated Show resolved Hide resolved
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
@garronej garronej merged commit 7b9dac8 into codegouvfr:main Jun 8, 2023
garronej added a commit that referenced this pull request Jun 12, 2023
* fix: optional title for alert components

* Update src/Alert.tsx

Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>

---------

Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
Co-authored-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
sbourdon13 pushed a commit to sbourdon13/react-dsfr that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants