Get FeatureRunner & ScenarioRunner ready for randomization #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
June 25, 2017 20:52
Scenario#lines returns the lines that make up the scenario in the file. The instance method on Feature returns the lines of that feature that should be run. Those are different things, and having the same name is likely to confuse.
|
@yarmiganosca, thanks for your PR! By analyzing the history of the files in this pull request, we identified @txus, @josepjaume and @divins to be potential reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second step of the refactor discussed in #196.
In order to easily and cleanly apply seeded randomization to both
Features andScenarios, we have to know whichFeatures andScenarios are going to get run before we start iteration.The 2 big changes are:
FeatureRunner#run, instead of directly iterating over thefilenamesarray, we use it to determine afeaturesarray and iterate over that.ScenarioRunner#run_scenarios!, instead of asking eachScenariois we should run it during iteration, we iterate over the array return by thescenarios_to_runprivate method.These changes provide us with a seam in each Runner where we can manipulate the order of their respective "runnables".
One small change that supports this:
Scenarionow knows every line that it takes up in it's file, instead of just the one it starts on.