Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Parser::parsePairs always escapes #1417

Merged
merged 1 commit into from
Nov 7, 2018
Merged

fix Parser::parsePairs always escapes #1417

merged 1 commit into from
Nov 7, 2018

Conversation

puschie286
Copy link
Contributor

Signed-off-by: Christoph Potas christoph286@googlemail.com

Description
The parser should only escape single values because parsePair is called recursive on each array.
Fix #1104

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@puschie286
~ dont escape pairs in Parser::parsePair
9937519 
Signed-off-by: Christoph Potas <christoph286@googlemail.com>
@lonnieezell lonnieezell merged commit cae88d9 into codeigniter4:develop Nov 7, 2018
@puschie286 puschie286 deleted the fix-pairparser-always-escapes branch September 24, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puschie286 @lonnieezell