Update date_helper.php #1515
Update date_helper.php #1515
Conversation
Add validate date string or time string. This should be in input filter i think. But still don't know how to integrate there
| */ | ||
| function validate_date(string $dateString):bool | ||
| { | ||
| $dateArr = explode('-', $dateString); |
There was a problem hiding this comment.
There is no way to know that a date string will be separated by dashes. In the US, I know that's common, but strtotime requires forward slashes to know it's a UK time and know which position the month and the day are. I'm sure this applies to other parts of the world, also, but, the point is you can't guarantee, so you'll need to find another way to get the date.
There was a problem hiding this comment.
I think we must have have another param to specify the date string format expected.
In Ci3, I use this : validate_date(string $dateString, string $dateFormat).
In france, the commonly format is dd/mm/yyyy.
There was a problem hiding this comment.
These function is supposed to validate input from <input type="date"> and <input type="time"> elements. Not from user input.
html input on MDN says that date value always yyyy-mm-dd. That is what sent to the server. That is different from displayed date which is regards on locale setting.
Also on validate_time respectively.
There was a problem hiding this comment.
If that's the intent, then it should be in a Validation rule, not the date helper. The date helper is for general usage, which this doesn't work for. However, this method already exists as a validation rule, so this appears to not be needed for what you intend.
There was a problem hiding this comment.
The validate_time method should be made a validation rule, as well.
Add validate date string or time string.
This should be in input filter i think. But still don't know how to integrate there