Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update view cell doc [ci skip] #3669

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Update view cell doc [ci skip] #3669

merged 1 commit into from
Sep 25, 2020
+3 −3

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Sep 22, 2020 •
edited
Loading

Description
Fixes #3668 .

Along the way, I found a teeny error in intro/index so I fixed that too.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

michalsn
michalsn requested changes Sep 24, 2020
View reviewed changes
user_guide_src/source/intro/index.rst Outdated Show resolved Hide resolved
@paulbalandan
Copy link
Member Author

Extracted the intro/index changes to a separate PR, #3681 . Never expected this to grow that much. 😂

Also, sorry for two topics on one PR. I've learned my lesson there. :)

@MGatner MGatner merged commit c48908d into codeigniter4:develop Sep 25, 2020
@paulbalandan paulbalandan deleted the view-cell-docs branch September 25, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@michalsn michalsn Awaiting requested review from michalsn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation Error
3 participants
@paulbalandan @michalsn @MGatner