Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless "raw html" #4131

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

totoprayogo1916
Copy link
Contributor

@totoprayogo1916 totoprayogo1916 commented Jan 18, 2021

Description
I think it's useless,

.. raw:: html	

  <div class="custom-index container"></div>

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Jan 18, 2021

I don't think these have any purpose. @paulbalandan do you know?

@paulbalandan
Copy link
Member

The raw:: html actually embeds the following HTML into the generated HTML file instead of displaying it. I'm not sure if the div classes are actually used or defined in the user guide's CSS.

@paulbalandan
Copy link
Member

@totoprayogo1916 can you show a before and after render of the user guide from this PR?

@totoprayogo1916
Copy link
Contributor Author

@paulbalandan : its found at contributing/documentation

but when render is not effect ,
after render, it just create empty div tag like:
image

@paulbalandan
Copy link
Member

@totoprayogo1916 yes it will just be put there. Can you show me what the page looks like with this div and after removing it. I am thinking maybe this div is controlling the clear: both css property. But if there's no noticeable change, I am fine removing those blocks.

@totoprayogo1916
Copy link
Contributor Author

@totoprayogo1916
Copy link
Contributor Author

and no specific CSS here
image

@paulbalandan
Copy link
Member

Then, it is really useless. 😂

@paulbalandan paulbalandan merged commit 189e184 into codeigniter4:develop Jan 18, 2021
@totoprayogo1916 totoprayogo1916 deleted the hf75ko23 branch January 18, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants