fix(cache): add check for redis empty results in deleteMatching #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassinedoghri
force-pushed
the
fix/cache-deleteMatching
branch
from
7b7e0a3
to
4877fb7
Compare
- update deleteMatching tests to check prefix and suffix patterns against a significant pool of items: --> tests weren't suppose to pass previously, but they did because of the small number of tested items. - return number of deleted matched items in deleteMatching instead of success or failure - update user_guide
- perf(FileHandler): do not sort files when using glob - update docstrings
yassinedoghri
force-pushed
the
fix/cache-deleteMatching
branch
from
d59c4eb
to
b31b38c
Compare
paulbalandan
approved these changes
May 1, 2021
|
Thank you, @yassinedoghri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The deleteMatching implementation for the RedisHandler is not deleting all matching cache items as intended.
This PR is meant to fix that bug and fix the tests that were supposed to fail.
Also, the deleteMatching method now returns the number of deleted items as it is offers better feedback than true/false (mainly for testing purposes).
Thanks to @benjaminbellamy for the heads up!
Checklist: