Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite3 "nullable" #4749

Merged
merged 1 commit into from
May 27, 2021
Merged

SQLite3 "nullable" #4749

merged 1 commit into from
May 27, 2021

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented May 27, 2021

Description
The correct Forge attribute for handling null columns is "null", not "nullable":

if (isset($attributes['NULL']))

Super scary to me that this has always been wrong and never been reported. 😳 Fixes #4746

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@MGatner MGatner merged commit 2c3f989 into codeigniter4:develop May 27, 2021
@MGatner MGatner deleted the sqlite-nullable branch May 27, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SQLite Drop Column
3 participants