Document new coding style guide #4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGatner
requested changes
Jun 14, 2021
|
@paulbalandan is this ready to merge? |
paulbalandan
force-pushed
the
coding-style-docs
branch
from
3e5a043
to
fcaeb55
Compare
kenjis
approved these changes
Sep 4, 2021
MGatner
requested changes
Sep 4, 2021
I think I did not follow what you want ? |
|
I would like some mention that the coding style is enforced by CS Fixer, with a link to the CodeIgniter/style-guide repo and a one-sentence introduction on what this is/does. I can suggest the change when I'm on desktop later if that would be helpful. |
|
@MGatner v4.1.4 was released. Why don't you merge this for now? |
|
Yes this needs to get in - I will make that addition today. |
MGatner
requested changes
Sep 8, 2021
Co-authored-by: MGatner <mgatner@icloud.com>
MGatner
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start documenting the new coding style rules and conventions. Most of here are from PSR-12 with a non-exhaustive list of our "custom" rules. After this, anyone can contribute adding to the customized rules section basing upon our enforced CS.
Checklist: