Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Entity's isset() and unset() #5497

Merged
merged 4 commits into from
Jan 19, 2022
Merged

fix: Entity's isset() and unset() #5497

merged 4 commits into from
Jan 19, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 24, 2021 •
edited
Loading

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 24, 2021
samsonasik
samsonasik reviewed Jan 1, 2022
View reviewed changes
system/Entity/Entity.php Outdated Show resolved Hide resolved
@kenjis kenjis requested a review from samsonasik January 1, 2022 23:57
MGatner
MGatner approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this system is a bit too confusing, but this is a step in the right direction. We might consider a different way to handle this in version 5.

@MGatner MGatner added the next major version? Read this for a relevant v5 idea label Jan 19, 2022
@kenjis
Copy link
Member Author

kenjis commented Jan 19, 2022

Yes, this is very confusing. At first I didn't understand which is correct the documentation or the implementation.
It is not good design.

@kenjis kenjis merged commit 00c2825 into codeigniter4:develop Jan 19, 2022
@kenjis kenjis deleted the fix-entity-isset-unset branch January 19, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@samsonasik samsonasik Awaiting requested review from samsonasik

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them next major version? Read this for a relevant v5 idea
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Can't unset mapped property in Entitiy
4 participants
@kenjis @samsonasik @MGatner @crustamet