Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forceGlobalSecureRequests break URI schemes other than HTTP #5730

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 24, 2022

Description
Fixes #5728

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 24, 2022
@kenjis kenjis force-pushed the fix-forceGlobalSecureRequests-and-other-than-HTTP branch from 6cc31fc to 97640c9 Compare February 24, 2022 00:41
@kenjis
Copy link
Member Author

kenjis commented Feb 24, 2022

@MGatner

URI should not be in the business of dealing with baseURL at all, but since this is currently the case we can't remove it entirely. #4646

What's happened if it is removed?

@MGatner
Copy link
Member

MGatner commented Feb 24, 2022

There's a lot of functionality based on URI and people have been told to use it for working with their project URLs. I even made a PR at one point to split these into two classes but ultimately it was too complicated. For now we need to leave this and plan to change it in version 5.

@kenjis kenjis merged commit 200a04e into codeigniter4:develop Feb 24, 2022
@kenjis kenjis deleted the fix-forceGlobalSecureRequests-and-other-than-HTTP branch February 24, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: enabled forceGlobalSecureRequests prevents uri schemes besides http/https
3 participants