Fix fatal error gets turned to 0 severity on shutdown handler
#6472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
shutdown-handler
branch
from
a239ba9
to
f94fb2b
Compare
kenjis
added
the
bug
kenjis
reviewed
Sep 2, 2022
| @@ -177,7 +177,7 @@ public function shutdownHandler() | |||
| ['type' => $type, 'message' => $message, 'file' => $file, 'line' => $line] = $error; | |||
|
|
|||
| if (in_array($type, [E_ERROR, E_CORE_ERROR, E_COMPILE_ERROR, E_PARSE], true)) { | |||
| $this->exceptionHandler(new ErrorException($message, $type, 0, $file, $line)); | |||
| $this->exceptionHandler(new ErrorException($message, 0, $type, $file, $line)); | |||
There was a problem hiding this comment.
Looks good.
public ErrorException::__construct(
string $message = "",
int $code = 0,
int $severity = E_ERROR,
?string $filename = null,
?int $line = null,
?Throwable $previous = null
)severity
The severity level of the exception.
Note:
While the severity can be any int value, it is intended that the error constants be used.
kenjis
approved these changes
Sep 2, 2022
MGatner
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6454
Checklist: