Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Parser] ! does not work if delimiters are changed #7142

Merged
merged 4 commits into from
Jan 22, 2023
Merged

fix: [Parser] ! does not work if delimiters are changed #7142

merged 4 commits into from
Jan 22, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 17, 2023

Description
From https://forum.codeigniter.com/showthread.php?tid=86155

  • fix ! does not work if delimiters are changed

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 17, 2023
MGatner
MGatner approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not gonna try to grok that regex, code & test looks good!

@kenjis kenjis merged commit 2877ecc into codeigniter4:develop Jan 22, 2023
@kenjis kenjis deleted the fix-parser-exclamation-mark branch January 22, 2023 00:45
@kenjis
Copy link
Member Author

kenjis commented Jan 22, 2023

@MGatner Thank you for reviewing!
Few members seem interested in Parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner