Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added revokeAccessTokenBySecret #838

Closed
wants to merge 2 commits into from
Closed

Added revokeAccessTokenBySecret #838

wants to merge 2 commits into from

Conversation

WaaaghNL
Copy link
Contributor

@WaaaghNL WaaaghNL commented Sep 16, 2023 •
edited

Description
After losing some tokens while i developed my app and i didnt want to remove all of the tokens i changed the revokeAccessToken to support removeing them by the secret that you can get with the AccessTokens() function.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the enhancement New feature or request label Sep 16, 2023
@datamweb
Copy link
Collaborator

@WaaaghNL Please do not include merge commits Read.

@WaaaghNL
Copy link
Contributor Author

I saw it, still figuring out git. My bad sorry

@kenjis kenjis added the waiting for info Issues or pull requests that need further clarification from the author label Sep 22, 2023
@datamweb datamweb added the stale Pull requests with conflicts label Sep 24, 2023
@WaaaghNL
Copy link
Contributor Author

@kenjis i think that i'm missing something. What kind of information are we waiting for?

@datamweb
Copy link
Collaborator

datamweb commented Sep 25, 2023 •
edited

@WaaaghNL currently, this PR is conflicting.
You need to update your branch and fix the conflict.
If you don't know how to use Git well, you can send a new PR.

@kenjis
Copy link
Member

kenjis commented Sep 25, 2023

Yes, update your PR branch and resolve the conflicts.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

@WaaaghNL WaaaghNL closed this by deleting the head repository Sep 26, 2023
@datamweb datamweb mentioned this pull request Sep 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request stale Pull requests with conflicts waiting for info Issues or pull requests that need further clarification from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WaaaghNL @datamweb @kenjis